omeka-s-themes / thedaily

GNU General Public License v3.0
4 stars 10 forks source link

Test PDF support #46

Closed kimisgold closed 2 years ago

kimisgold commented 2 years ago

Test that PDFs appear within the lightgallery, both standalone and alongside other visual media. This is the same feature introduced in Center Row's lightgallery, where PDFs appear in the lightgallery viewer alongside browser-supported images, youtube, and html5 videos.

This feature is on the master branch and should be tested on all major browsers for both desktop and mobile devices.

sharonmleon commented 2 years ago

Same results as with Center Row:

Testing on a Mac with FFX, Chrome, and Safari.

PDFs appear in the light gallery on all browsers.

With FFX and Chrome the PDF wrapper includes the zoom and download controls. In the light gallery interface there are zoom controls, but they don't work.

In Safari there are no PDF wrapper zoom controls or download, and in the light gallery zoom controls do not work. Download does work in the light gallery interface.

kimisgold commented 2 years ago

In the light gallery interface there are zoom controls, but they don't work.

This is expected behavior: lightgallery disables zoom controls for video and pdf. It's theoretically lower opacity, but I may hide it altogether to eliminate ambiguity.

In Safari there are no PDF wrapper zoom controls or download

This seems to be dependent on how the browser wants to handle PDF support. In Safari, I see this minimal overlay of controls.

image
sharonmleon commented 2 years ago

I must have missed them on Safari. Just not expecting them to be at the bottom.

Same results for FFX and Chrome on Windows. No PDF wrapper controls for Edge.

kimisgold commented 2 years ago

The PDF controls wrapper for Edge seems to be resolution-dependent and external to anything the theme can do. Everything within its control seems to work as expected.