omeka / MallMap

0 stars 4 forks source link

Consider moving hard coded IDs to constants #1

Closed jimsafley closed 11 years ago

jimsafley commented 11 years ago

In MallMap_IndexController item type IDs and element IDs are hard coded in $_formData property. Since IDs may change in the future, it may be best to move them to class constants. This way ID variables in filterAction() can be changed to constants. Unfortunately it's not practical to move item type names and element texts to constants.