omeka / Omeka

A flexible web publishing platform for the display of library, museum and scholarly collections, archives and exhibitions.
http://omeka.org
GNU General Public License v3.0
472 stars 193 forks source link

Advanced Search fields need wrap for long entries #1006

Closed allanaaa closed 1 year ago

allanaaa commented 1 year ago

I imported items from a site that has some really long collection titles. (Presumably also an issue for long exhibit titles.)

On Advanced Search, many of the themes deal with this really well. Here are the ones that need some kind of width constraint:

Berlin berlin-search

Emiglio emiglio-search

Foundation foundation-search

Minimalist minimalist-search

Rhythm rhythm-search

Seasons seasons-search

It would be nice if there was a one-stop solution in core, but I'm guessing this is a theme-by-theme issue. Sorry for the compound issue!

zerocrates commented 1 year ago

Core can provide styles out to the themes now, though I don't know if it makes sense to do so in this situation.

kimisgold commented 1 year ago

@allanaaa I think I've addressed all the affected themes, and they should be ready for testing.

allanaaa commented 1 year ago

Fantastic, everything looks great.

Only one other thing to note:

In Berlin, the Exhibits plugin adds an advanced search field inconsistent with the other fields. It doesn't make a difference visually in any other theme, but in Berlin they end up side-by-side instead of label on top of field.

berlin-exhibit

Probably the code in the Exhibits plugin needs to be changed rather than the theme? The exhibit field has this extra div class="two columns alpha" and then some extra classes (five columns omega) on the inputs div that the other ones don't have. Seems to be the columns, two, and five that are having unintended effects.

        <div id="search-by-public" class="field">
        <label for="public">Public/Non-Public</label>        <div class="inputs">
        <select name="public" id="public">
    <option value="">Select Below </option>
    <option value="1">Only Public Items</option>
    <option value="0">Only Non-Public Items</option>
</select>        </div>
    </div>

    <div id="search-by-featured" class="field">
        <label for="featured">Featured/Non-Featured</label>        <div class="inputs">
        <select name="featured" id="featured">
    <option value="">Select Below </option>
    <option value="1">Only Featured Items</option>
    <option value="0">Only Non-Featured Items</option>
</select>        </div>
    </div>

    <div class="field">
    <div class="two columns alpha">
        <label for="exhibit">Search by Exhibit</label>    </div>
    <div class="five columns omega inputs">
        <select name="exhibit" id="exhibit">
    <option value="">Select Below </option>
    <option value="1">Exhibit: A Groat's Worth of  Wit for a Penny</option>
zerocrates commented 1 year ago

We should probably just fix that in Exhibit Builder.

kimisgold commented 1 year ago

I've just updated Exhibit Builder to address this. I noticed Geolocation fields were doing the same thing, so they've gotten the same fixes.

allanaaa commented 1 year ago

That's fixed it, thanks!