search

omeka / Omeka

A flexible web publishing platform for the display of library, museum and scholarly collections, archives and exhibitions.
http://omeka.org
GNU General Public License v3.0
472 stars 193 forks source link

Minor deprecation warning fix in Zend_Ldap. #1013

Closed kloor closed 7 months ago

kloor commented 7 months ago

This fixes a minor deprecation warning caused by Zend_Ldap attempting to str_replace() on null, for plugins adding LDAP support to Omeka Classic via the Zend libraries.

zerocrates commented 7 months ago

str_replace("\0", '', (string) $password) should be equivalent (just adding the cast to string): if that works fine for you that's the form of this fix I'd prefer.

kloor commented 7 months ago

That's fine with me, do you want me to update the PR?

zerocrates commented 7 months ago

That would be convenient, yeah.

zerocrates commented 7 months ago

Thanks.