search

omeka / Omeka

A flexible web publishing platform for the display of library, museum and scholarly collections, archives and exhibitions.
http://omeka.org
GNU General Public License v3.0
487 stars 194 forks source link

Every form in the plugins list creates a hidden input with a "csrf_token" id #721

Open kimisgold opened 8 years ago

kimisgold commented 8 years ago

Each of these inputs should have unique ids.

patrickmj commented 8 years ago

Do you mean on the admin plugins page? Or plugins adding their inputs to, e.g., the item edit tabs?

kimisgold commented 8 years ago

Admin plugins browse.

On Wednesday, July 13, 2016, Patrick Murray-John notifications@github.com wrote:

Do you mean on the admin plugins page? Or plugins adding their inputs to, e.g., the item edit tabs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/omeka/Omeka/issues/721#issuecomment-232369802, or mute the thread https://github.com/notifications/unsubscribe/AAlCLGiIkfgnv2c6FocvHybMVGfDd9fmks5qVPQcgaJpZM4JK_44 .

Kim Nguyen Web Designer Roy Rosenzweig Center for History and New Media

patrickmj commented 8 years ago

ugh. yeah. now i see it

zerocrates commented 8 years ago

The only simple way to fix this is to trade one validation problem for another: we can get Zend's form code to output a blank-string ID, but not to omit it entirely. In practice the browsers uniformly seem to ignore blank IDs, but it is a violation of the standard (see #701).