Closed allanaaa closed 2 years ago
Oh yeah, and jury's still out on whether you should capitalize "boolean."
Fixes #32 now too.
A recap of the major stuff:
More detailed notes with each commit.
The easiest way to see it all is to skim the changes https://github.com/omeka/classic-enduser/pull/44/files and see if anything jumps out at you for review.
I did some testing to verify some of the early pages, stuff in Content and Admin, so if there are meaningful language changes to check up on, they'll be there. I didn't do any technical stuff on the plugins page or after, so those can be skimmed quickly.
Re: Database vs. collections vs. archive. As much as possible we would like to eliminate the use of the word archive. Generally I like collection, but that can be confusing in the context of Omeka Classic where Collections are a feature. As a result, I tend to default to repository of items.
Question about the specifying the colors of the elements of the interface in the narrative documentation: does this create accessibility confusion based on the perception of the color names? I.e. does teal mean too many different things to too many different people?
On the styling for feature lists, etc.: In some cases you’ve converted colons to periods, but not all (see Admin General Settings). So changing
To
We have tended to use the colon, but I’m happy to go with the change if it’s consistent
I think that we're okay with the redundancy in the Item Type Element Set documentation because the edit interface does engages both in the left hand navigation and in the General Settings section.
I.e. does teal mean too many different things to too many different people?
Fair question. The original alt text referred to a red arrow, which I suppose was from a previous image version, so I just updated it. I don't find the teal arrows very visible either. Might be best to redo some of the image annotations in higher contrast and redo the alt text again. (I assume teal was chosen from the branding colours....)
On the styling for feature lists, etc.: In some cases you’ve converted colons to periods, but not all (see Admin General Settings). So changing
* **Feature:** Definition
To
* **Feature.** Definition
We have tended to use the colon, but I’m happy to go with the change if it’s consistent
Yeah, I am still bouncing around some of these style-guide-y questions. When to use bold and italic, whether an "Interface Button" is different from an Interface link vs. a url/path
and what the dropdown options are, etc. etc. I mostly stopped in the interests of time, so these'll go into a future update when we do more substantive changes.
Perhaps something here about how the thumbnail and full sized service images have size settings in the general appearance settings.
I can't see what this refers to. Can you tell me the page you were on? Or I can make a note to cover it in the next update.
Here I think we can eliminate that use of "archive" for something more general like "your digital objects" or "your materials."
Same for this comment - there are quite a few mentions left, not sure which one in particular this refers to, but I've made a note to be more comprehensive on the next pass, unless you'd rather I zap them all now.
Those "here" comments from Sharon look like they're supposed to be line comments on the diff... Github can see that they're "reviews" but isn't showing what lines they go with for some reason.
That's super annoying. I'm working in the Github app which appears to let me comment on individual line diffs, as John suggests. I'll have to figure out some other way to do this.
If it helps, for me they show up attached to the lines when you look at the list of file changes....
If it helps, for me they show up attached to the lines when you look at the list of file changes....
I figured it must have been something like that. If you want to just write in some extra details manually about what files & lines, I can hunt them down and we can figure out the app-to-website issue later.
I'll circle back after I review some other stuff and make a list of the files and lines.
Looks great, thanks! I'll get on these ASAP. Could you also merge #42 if you're happy with it for now?
I haven't looked at that one yet, but I'll get there ASAP.
@sharonmleon @zerocrates Anything else to add to or remove from this PR before it gets merged? The only outstanding is whether you want me to do a sweep to remove contractions.
No worries on the contractions.
First pass.
Notes: