search

omeka / omeka-s-developer

Documentation for Omeka S developers
Other
18 stars 37 forks source link

Proposed changes to address Issue 56 #57

Closed triplingual closed 4 years ago

triplingual commented 4 years ago

Honestly, I haven't been able to get limit and offset to work, but otherwise I think this is accurate.

zerocrates commented 4 years ago

Honestly, I haven't been able to get limit and offset to work

Basically, limit and offset are designed for use in the PHP-side API endpoint, not the REST: the browse actions and the API "search" operation both automatically imply use of the pagination system, and when that's being used, limit and offset are ignored.

zerocrates commented 4 years ago

I agree that we should include these default values in the documentation.

One minor note on the defaults you've listed: the default per page limit is controlled by the global "results per page" setting, so it can differ from installation to installation.

triplingual commented 4 years ago

Changed per_page default column value from 25 to "uses global 'results per page' setting".

Is this a brittle or undesirable link? I don't have a sense of whether you're trying to keep dev and end-user doco wholly separate.

zerocrates commented 4 years ago

I don't think there's any problem linking between the developer and user documentation like that.