search

omeka / omeka-s

Omeka S is a web publication system for universities, galleries, libraries, archives, and museums. It consists of a local network of independently curated exhibits sharing a collaboratively built pool of items, media, and their metadata.
GNU General Public License v3.0
410 stars 138 forks source link

Plan to make log psr-3 compliant #1183

Open Daniel-KM opened 6 years ago

Daniel-KM commented 6 years ago

In order to get translatable logs, and manageable logs with third party services, they must be psr-3 compliant (see details on http://www.php-fig.org/psr/psr-3/ or on my module (Daniel-KM/Omeka-S-module-Log). Is there a plan for that (it implies to modify all log messages that use sprintf)? Or will you accept a pull request for that?

zerocrates commented 6 years ago

This is the first I'd actually looked into PSR-3, I didn't realize it specifies a placeholder/interpolation system.

It's definitely not in any current plans but I'm not opposed to the idea. In general, I'm in favor of using broader standards where they're available and feasible rather than just Zend's stuff directly.

Daniel-KM commented 6 years ago

In fact, current messages are psr-3 compliant, because sprintf is used inside the message, so the logger never see placeholders "%s". But they are not translatable and not manageable, because "%s" are sprintf-ed, so each message is unique. So I'm going to do a pull request in February.