Mailer: 'from' in default_message_options overriden by administrator_email

omeka / omeka-s

Omeka S is a web publication system for universities, galleries, libraries, archives, and museums. It consists of a local network of independently curated exhibits sharing a collaboratively built pool of items, media, and their metadata.

GNU General Public License v3.0

401 stars 134 forks source link

Mailer: 'from' in default_message_options overriden by administrator_email #1685

Closed jajm closed 3 years ago

jajm commented 3 years ago

Hi,

I just stumbled upon these lines: https://github.com/omeka/omeka-s/blob/f7a5cadaa2d7c02fd256eb89aeb9694d7b4a9dee/application/src/Service/MailerFactory.php#L29-L32

Which I understand as "If administrator_email is not set, then set from". It looks like it's not the intended behaviour. Shouldn't it be:

if (!isset($defaultOptions['from'])) {

zerocrates commented 3 years ago

I think you're right about that. I'll check into it some more but I believe you're correct about what's intended there.

zerocrates commented 3 years ago

Yes, it was definitely a bug/typo. Thanks for the report.

jajm commented 3 years ago

Thanks for fixing it :)