search

omeka / plugin-Contribution

Makes an Omeka site into one that accepts public contributions. The plugin provides a form to collect stories, images, or other files from the public and manages those contributions in your Omeka archive as items. This contribution is useful when creating digital memory banks
http://omeka.org/codex/Plugins/Contribution
8 stars 15 forks source link

Review strings edited to avoid ending links #74

Closed kimisgold closed 2 years ago

kimisgold commented 2 years ago

If a sentence ends with a link, screen readers will read out the periods. The link-position-edits branch adjusts strings so that links appear earlier in any sentences ending in a period and should also include an updated template.pot. I need someone to check that the changes read okay and the template file was properly updated before I merge this.

kimisgold commented 2 years ago

I had missed that this was for Omeka.net's version of Contribution on the net branch. The link-position-edits branch was created off of master. For simplicity's sake, @zerocrates recommended removing the problematic periods. Those changes are now in place in https://github.com/omeka/plugin-Contribution/commit/4017bf6fbca30f38f55570afa89569c132bfd028 on the net branch. If we make similar edits for Omeka Classic's version, this would avoid us having to change a slew of translatable strings.

Also it may not actually be an issue? John referenced this thread discussing screen readers reading out periods after links possibly being expected behavior. There's also a Deque write up on punctuation that discusses configuration in screen readers that allows users to set the level of verbosity regarding punctuation.