search

omeka / plugin-Reports

Generates report documents from Omeka items.
6 stars 5 forks source link

getName isn't a 1.x or 2.0 method for User #7

Closed zerocrates closed 13 years ago

zerocrates commented 13 years ago

see https://github.com/omeka/plugin-Reports/blob/master/controllers/IndexController.php#L49

Appears to be relying on a method in Mu_Model_User.

kriskelly commented 13 years ago

Actually this is a method on Entity. creator_id used to refer to the entity id, but since that makes no sense, I reverted it to user_id.

zerocrates commented 13 years ago

Well, the issue is, calling $user->getName() works on MU, and not on standalone, either version.

The only difference I saw between them is that there's an explicit getName in Mu_Model_User.

kriskelly commented 13 years ago

Ok, easy fix would be to implement getName() on User. Otherwise just reverting to something like:

$user->first_name . ' ' . $user->last_name

On Aug 17, 2011, at 1:15 PM, zerocrates wrote:

Well, the issue is, calling $user->getName() works on MU, and not on standalone, either version.

The only difference I saw between them is that there's an explicit getName in Mu_Model_User.

Reply to this email directly or view it on GitHub: https://github.com/omeka/plugin-Reports/issues/7#issuecomment-1830137