search

omeka / plugin-SimpleContactForm

Generates a short form that allows users to contact a designated individual and for the site to automatically respond to inquiries with an acknowledgment page and email.
http://omeka.org/codex/Plugins/SimpleContactForm
5 stars 10 forks source link

Ever heard about client-side validation?? #18

Open teo1978 opened 5 years ago

teo1978 commented 5 years ago

Steps to reproduce:

  1. Install and activate the plugin
  2. Go to the Contact Us page
  3. Fill in the form incompletely, leaving out some required field or entering some invalid data
  4. Submit the form

Expected: Client-side validation should be performed before sending the data, and given there are validation errors, they should be displayed immediately and the form not sent (of course, server-side validation must be always done regardless, in case the data does get sent for whatever reason).

Observed: There is no client-side validation, as if we were in the 1990s; the form gets sent and the response from the server with validation errors is shown. It works fine, but there's no client-side validation and the user needs to wait for the entire round-trip request/response just to get validation errors.

zerocrates commented 5 years ago

Please stay constructive when posting issues. This issue's title and its ending are unnecessary and unhelpful.

DBinaghi commented 4 years ago

There is no client-side validation, as if we were in the 1990s; the form gets sent and the response from the server with validation errors is shown. It works fine, but there's no client-side validation and the user needs to wait for the entire round-trip request/response just to get validation errors.

@teo1978, could you please provide some example of how would you edit/fix the code, so that it might be implemented? Thanks