search

omeka / plugin-Timeline

Create TimelineJS timelines accessible via ExhibitBuilder blocks or shortcode.
0 stars 1 forks source link

Remove dangling commas from hookDefineRoutes #12

Closed dicksonlaw583 closed 1 year ago

dicksonlaw583 commented 1 year ago

This prevents the plugin from crashing the plugins admin screen when Omeka runs on PHP 7.x.

zerocrates commented 1 year ago

@matthewjmckinley Context: trailing commas are always legal in arrays but are a newer allowed syntax in function signatures, and these are outside the array and are in the function signature.

I believe its only PHP 7.3 and up that allow trailing commas in function calls.