Test updates for Omeka 2.1

patrickmj commented 11 years ago

@sheilabrennan We're ready for a look-through of Berlin. Especially interested in how content from plugins appears, and whether plugins' styles stay relatively consistent in Berlin and other themes. (For example, GuestUser needs a fix for where the dropdowns float)

leeannghajar commented 11 years ago

Initial issue with Berlin layout occurs on desktop, but not on mobile. Extra items added to top navigation create two rows which over lap with each other and with page content. Occurs on all browsers, pc and mac. screen shot 2013-07-02 at 12 20 06 pm

Addition of recommended max width 500 px logo file functional on mobile; desktop, not so much: screen shot 2013-07-02 at 1 20 36 pm

Ditto header test. On mobile, header image drops below menu. screen shot 2013-07-02 at 1 27 15 pm

Note that on mobile view, search boxes are misaligned in Firefox on mac [see above image], but not in Chrome or Safari, and not on PC

leeannghajar commented 11 years ago

Shading in background of FEatured item, home page visible on PC, invisible on Mac. Featured Collection appears misalignedon all browsers without header/paragraph padding/margin comparable to Featured Item. Screenshot is from Firefox, mac. [segue: suggest smaller line-height on h2] screen shot 2013-07-03 at 8 37 26 am

leeannghajar commented 11 years ago

In Berlin, Browse Item page view, thumbnails do not conform to requested size in Settings across browsers. They're too large and blurry. Elsewhere on the site and in other themes, thumbnails conform to requested 50px setting for this site. screen shot 2013-07-03 at 9 53 15 am

kimisgold commented 11 years ago

Berlin has been updated with the following:

Updated <title> formats in the <head>
- In the window's tab, the title should read "[Current Page] · [Omeka Site Title]"
Margin corrections on radio inputs and navigation lists
- When I switched the "reset" styles from Compass's built-in styles to those of normalize.css, a lot of <ul>s went back to their default left padding. Navigations lists such as the items/browse subnav should be flush left again.
- Radio inputs, such as those in the advanced site-wide search dropdown form, should have a little more breathing room between the inputs and their labels.
Better scaling for logo images
- The logo image should never overlap with the search bar. It should also take up the whole width of the page at mobile device resolutions.
Wrapping for several rows of navigation tabs
- The tabs in the second row of primary navigation tabs should have borders on all sides of each item. It still doesn't look particularly elegant, but this theme really wasn't intended to have more than one row of navigation items.
New styles for search filters
- Search filters should now be inline with each other, meaning they don't take up as much vertical space.
- Old:
  Query: bridge
  Query type: Keyword
  Record types: Item File Collection
- New: Query: bridge · Query type: Keyword · Record types: Item File Collection
Improved layout of item meta on items/browse
- Previously, an item with no description but was tagged would show tags in the middle of the row with a lot of top margin. It should now appear at the top of the row.

I'd appreciate it if testers could pull the most recent updates and look at Berlin again. Who else is testing other than @leeannghajar?

sharonmleon commented 11 years ago

This should include @jhalabuk too.

Sharon M. Leon, Ph.D. Director of Public Projects, Roy Rosenzweig Center for History and New Media and Associate Professor, Dept of History and Art History George Mason University 4400 University Drive, MSN 1E7 Fairfax VA 22030

703-993-3831 @sleonchnm sleon@gmu.edu sharonmleon@gmail.com http://chnm.gmu.edu/ http://6floors.org/bracket/

On Tue, Jul 9, 2013 at 6:02 PM, Kim Nguyen notifications@github.com wrote:

Berlin has been updated with the following:

Updated formats in the <head></li> <li>Margin corrections on radio inputs and navigation lists</li> <li>Better scaling for logo images</li> <li>Wrapping for several rows of navigation tabs</li> <li>New styles for search filters</li> <li>Improved layout of item meta on items/browse</li> </ul> <p>I'd appreciate it if testers could pull the most recent updates and look at Berlin again. Who else is testing other than @leeannghajarhttps://github.com/leeannghajar ?</p> <p>— Reply to this email directly or view it on GitHubhttps://github.com/omeka/theme-berlin/issues/7#issuecomment-20708822 .</p> </blockquote> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/patrickmj"><img src="https://avatars.githubusercontent.com/u/153262?v=4" />patrickmj</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>Important note -- last I heard, these changes in Berlin were on a branch called <code>reskeleton</code>. So all should do <code>git pull</code> and just to make sure <code>git checkout reskeleton</code>, and <code>git pull</code> again.</p> <p>Also if I remember right, these changes could be fairly subtle. Cross browser quick looks should reveal anything egregiously weird. @kimisgold, could you provide more precise details of what @leeannghajar and @jhalabuk should pay close attention to, and what counts as a problem and what doesn't?</p> <p>A detailed "I expect you to see <strong>__</strong> ; do you see that?" structure on top of the bullet points might help elicit more focused feedback.</p> <p>Sounds like a good late-breaking topic for the Wednesday meeting, which is all good.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/kimisgold"><img src="https://avatars.githubusercontent.com/u/606764?v=4" />kimisgold</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>I've updated my initial list with further details of what we should be looking for. As a general principle, I'm happy with receiving any observed oddities and then sorting out for myself what's actually a problem—inconsistent margins, misaligned elements, areas that could be improved.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/leeannghajar"><img src="https://avatars.githubusercontent.com/u/1831142?v=4" />leeannghajar</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>@kimisgold @patrickmj Two quick ones from fast run-through in Firefox/Safari on Mac [reskeleton checkout/pull]. [PC/Windows tomorrow] Kim's listed items appear/function as intended. However, please note that in responsive/mobile view, pins and popups do not show up on map <img src="https://f.cloud.github.com/assets/1831142/772593/0fd440ba-e912-11e2-8450-3ae0ff78d606.png" alt="screen shot 2013-07-09 at 11 14 26 pm" /></p> <p>EMBEDDED ITEMS Embed items, using plugin, are too wide for thumbnail on mobile view. <img src="https://f.cloud.github.com/assets/1831142/772597/3333f9c4-e912-11e2-88fb-9a86a830208c.png" alt="screen shot 2013-07-09 at 11 27 56 pm" /></p> <p>And oddly configured on full-screen view. <img src="https://f.cloud.github.com/assets/1831142/772599/3ecc9ade-e912-11e2-87b5-43b4e5742ff8.png" alt="screen shot 2013-07-09 at 11 36 52 pm" /></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/zerocrates"><img src="https://avatars.githubusercontent.com/u/298975?v=4" />zerocrates</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>I can only assume this issue has been finished favorably?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/sheilabrennan"><img src="https://avatars.githubusercontent.com/u/741484?v=4" />sheilabrennan</a> commented <strong> 11 years ago</strong> </div> <div class="markdown-body"> <p>Yes</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

omeka / theme-berlin

Test updates for Omeka 2.1 #7