Closed patrickmj closed 11 years ago
Initial issue with Berlin layout occurs on desktop, but not on mobile. Extra items added to top navigation create two rows which over lap with each other and with page content. Occurs on all browsers, pc and mac.
Addition of recommended max width 500 px logo file functional on mobile; desktop, not so much:
Ditto header test. On mobile, header image drops below menu.
Note that on mobile view, search boxes are misaligned in Firefox on mac [see above image], but not in Chrome or Safari, and not on PC
Shading in background of FEatured item, home page visible on PC, invisible on Mac. Featured Collection appears misalignedon all browsers without header/paragraph padding/margin comparable to Featured Item. Screenshot is from Firefox, mac. [segue: suggest smaller line-height on h2]
In Berlin, Browse Item page view, thumbnails do not conform to requested size in Settings across browsers. They're too large and blurry. Elsewhere on the site and in other themes, thumbnails conform to requested 50px setting for this site.
Berlin has been updated with the following:
<title>
formats in the <head>
<ul>
s went back to their default left padding. Navigations lists such as the items/browse subnav should be flush left again.I'd appreciate it if testers could pull the most recent updates and look at Berlin again. Who else is testing other than @leeannghajar?
This should include @jhalabuk too.
Sharon M. Leon, Ph.D. Director of Public Projects, Roy Rosenzweig Center for History and New Media and Associate Professor, Dept of History and Art History George Mason University 4400 University Drive, MSN 1E7 Fairfax VA 22030
703-993-3831 @sleonchnm sleon@gmu.edu sharonmleon@gmail.com http://chnm.gmu.edu/ http://6floors.org/bracket/
On Tue, Jul 9, 2013 at 6:02 PM, Kim Nguyen notifications@github.com wrote:
Berlin has been updated with the following:
- Updated
formats in the - Margin corrections on radio inputs and navigation lists
- Better scaling for logo images
- Wrapping for several rows of navigation tabs
- New styles for search filters
- Improved layout of item meta on items/browse
I'd appreciate it if testers could pull the most recent updates and look at Berlin again. Who else is testing other than @leeannghajarhttps://github.com/leeannghajar ?
— Reply to this email directly or view it on GitHubhttps://github.com/omeka/theme-berlin/issues/7#issuecomment-20708822 .
Important note -- last I heard, these changes in Berlin were on a branch called reskeleton
. So all should do git pull
and just to make sure git checkout reskeleton
, and git pull
again.
Also if I remember right, these changes could be fairly subtle. Cross browser quick looks should reveal anything egregiously weird. @kimisgold, could you provide more precise details of what @leeannghajar and @jhalabuk should pay close attention to, and what counts as a problem and what doesn't?
A detailed "I expect you to see __ ; do you see that?" structure on top of the bullet points might help elicit more focused feedback.
Sounds like a good late-breaking topic for the Wednesday meeting, which is all good.
I've updated my initial list with further details of what we should be looking for. As a general principle, I'm happy with receiving any observed oddities and then sorting out for myself what's actually a problem—inconsistent margins, misaligned elements, areas that could be improved.
@kimisgold @patrickmj Two quick ones from fast run-through in Firefox/Safari on Mac [reskeleton checkout/pull]. [PC/Windows tomorrow] Kim's listed items appear/function as intended. However, please note that in responsive/mobile view, pins and popups do not show up on map
EMBEDDED ITEMS Embed items, using plugin, are too wide for thumbnail on mobile view.
And oddly configured on full-screen view.
I can only assume this issue has been finished favorably?
Yes
@sheilabrennan We're ready for a look-through of Berlin. Especially interested in how content from plugins appears, and whether plugins' styles stay relatively consistent in Berlin and other themes. (For example, GuestUser needs a fix for where the dropdowns float)