omeka / theme-seasons

A colorful theme with a configuration option to switch style sheets for a particular season. For version 1.2 and above, Seasons offers the style sheets of earlier themes, Spring, Summer, Fall, Winter.
http://omeka.org/add-ons/themes/
GNU General Public License v3.0
6 stars 15 forks source link

style.css encoding problems #37

Closed JBPressac closed 2 months ago

JBPressac commented 1 year ago

Hello,

Seems that there are encoding problems in style.css:

  .pagination_previous a:after {
    content: "";
  }

  .pagination_next a:after {
    content: "";
  }

...

  #search-form button:after {
    font-family: "Font Awesome 5 Free";
    font-weight: 900;
    content: "";
...
  .asc a:after {
    content: "";
  }

  .desc a:after {
    content: "";
  }
...
  nav.top .sub-nav ul a:before {
    font-family: "Font Awesome 5 Free";
    font-weight: 900;
    content: "";
    margin-right: 0.5em;
  }
  nav.top .sub-nav ul ul {
    padding-left: 1em;
  }
  nav.top .sub-nav li {
    display: block;
    list-style-type: none;
    margin: 0;
    padding: 0;
  }
  nav.top .sub-nav a:focus, nav.top .sub-nav a:hover {
    background-color: rgba(0, 0, 0, 0.05);
    display: block;
  }
  nav.top [aria-haspopup=true]:after {
    font-family: "Font Awesome 5 Free";
    font-weight: 900;
    content: "";
    margin-left: 0.5em;
    display: inline-block;
    width: 6px;
  }
  nav.top [aria-haspopup=true].open:after {
    content: "";
zerocrates commented 1 year ago

Are you seeing actual rendering problems associated with any of this?

Those are places specifying which iconfont characters to use, so they're supposed to be "weird" private-use characters that don't render as anything in source form.

JBPressac commented 1 year ago

I don't know where those icons are supposed to be displayed in the HTML pages and I did not found this problem because of HTML rendering problems. I did noticed it because the text editor I used to edit this file replaced the weird characters by a question mark. Besides those strange characters are in the GitHub source file.

In previous commit, the unicode characters corresponding to "weird characters" are correctly displayed (for instance, one  is displayed \f0d9). Which make me thing that the commit 'Edit theme styles against new public styles.' introduced an encoding problem in the source style.css file.

zerocrates commented 1 year ago

I don't believe this is an encoding problem. It's just how the compiler used on the CSS works: it changes the \f0d9 that we write in the .scss source styles into an actual Unicode character in the compiled .css file, because the character uses fewer bytes.