search

omeka / theme-seasons

A colorful theme with a configuration option to switch style sheets for a particular season. For version 1.2 and above, Seasons offers the style sheets of earlier themes, Spring, Summer, Fall, Winter.
http://omeka.org/add-ons/themes/
GNU General Public License v3.0
6 stars 15 forks source link

captcha's hidden inputs appear #6

Closed patrickmj closed 11 years ago

patrickmj commented 11 years ago

This is another one that raises the plugin vs. theme responsibility question.

Using Omeka_Captcha produces an input with class='hidden', but there's not a declaration to make those display:none;.

Is this more a responsibility of the plugin devs to make sure that they add the needed CSS, or is it better for themes in general to do something with class='hidden'?

zerocrates commented 11 years ago

Something doesn't sound right here. There's no general assumption that class=hidden would do anything. Recaptcha doesn't rely on preexisting styles for this, to my knowledge, unless maybe you pick a specific theme.

You're sure this is just a class that's supposed to do this?

patrickmj commented 11 years ago

That's what it looks like, but yeah. weird and not sounding right. This is what it looks like gets stuffed in

<input type="text" name="captcha" id="captcha" value="" class="hidden">

Same thing in thanks,roy. Maybe there's something funny with the decorator?

patrickmj commented 11 years ago

My bad. passing wrong data to formElement.

:sob: