search

omeralpi / shadcn-phone-input

Customizable phone input component with proper validation for any country. Built on top of shadcn.
https://shadcn-phone-input.vercel.app
MIT License
422 stars 28 forks source link

Update cmdk to 1.0.0 #21

Open edgarlcs opened 4 months ago

edgarlcs commented 4 months ago

-Updated cmdk to latest version (1.0.0) to have latest features -Added styles to CommandItem component to ensure disabled status is reflected properly -Fixes bug where items appear disabled even when data-disabled=false in the element

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-phone-input ❌ Failed (Inspect) Apr 4, 2024 4:46pm
JarvisPrestidge commented 4 months ago

@omeralpi could you looking into getting this merged 🙇

Given that cmdk has reached a stable version and everyone will be updating, essentially everyone will run into the disabled status issue with this package.

omeralpi commented 4 months ago

@omeralpi could you looking into getting this merged 🙇

Given that cmdk has reached a stable version and everyone will be updating, essentially everyone will run into the disabled status issue with this package.

We can't ignore the Shadcn ecosystem. I'm waiting for the Shadcn UI package to be updated.

https://github.com/shadcn-ui/ui/blob/main/apps/www/package.json#L57

https://github.com/shadcn-ui/ui/pull/3268 https://github.com/shadcn-ui/ui/pull/2945