search

omergertel / pyformance

Performance metrics, based on Coda Hale's Yammer metrics
Other
195 stars 72 forks source link

PEP8 compliance #63

Closed boarik closed 5 years ago

boarik commented 5 years ago

Thanks for this library!

I've gone over the code base and noticed diversions from the recommended PEP8 standard. A few stuff are more critical than others for readability and code cleanliness.

I thought of applying an automatic code formatter to this code such as black, what are your thoughts @omergertel ?

omergertel commented 5 years ago

I think it might be overkill, but since running it and seeing what happens is simple enough, would you be kind enough to open a PR so we can see the amount of changes?

I'm generally for auto formatters, but I'm not working with Python currently, so I don't want to add complexity to the product. This means I'd love to fix what we have, but I'm hesitant to add it as part of the CI.

boarik commented 5 years ago

Done #64 . Note I used the 100 chars line length variant, and included the core, test and example modules in the auto format.

Cheers

omergertel commented 5 years ago

Closed by #64