search

omersch381 / Money-Transaction-Tracker

Our Super Duper Greatest Final Project!!!
0 stars 0 forks source link

destinationName variable is empty in debtRequests and debtRotationRequests. #3

Open DrorTsky opened 3 years ago

DrorTsky commented 3 years ago

image

omersch381 commented 3 years ago

Thanks for raising the issue! Though I see that destinationName is one of ExchangeDetails attributes: https://github.com/omersch381/Money-Transaction-Tracker/blob/DebtRotation/src/solidity/contracts/ProfileContract.sol#L19

And it is supposed to be added for each relevant request: https://github.com/omersch381/Money-Transaction-Tracker/blob/DebtRotation/src/solidity/contracts/ProfileContract.sol#L146

But maybe I missed a use case. Can you please elaborate how did you get this bug so I could reproduce it?

DrorTsky commented 3 years ago

I took the exchanges I got from the getAllExchangesByIndex function and displayed them.

omersch381 commented 3 years ago

I could reproduce the bug with debt request and debt rotation request.

As the current solc version we use (0.4.17) doesn't allow more parameters to be sent to the addExchangeNotRestricted function because it claims that the Solidity stack is too deep, we can add a future patch that would patch the names of the exchanges participants (as the addresses are correct).