As a precaution to avoid the potential missing value bug in rpy2 3.5.7 and 3.5.8, I updated the polyfun.yml file to avoid these 2 versions. However, since I don't actually have any evidence that the bug will affect the polyfun code, I didn't explicitly throw an error in finemapper.py if one of those versions is installed. In other words, I'm directing users away from these versions, but not preventing a user if they for some reason really want to install one of those versions.
I compare the version strings using the 3rd party package packaging. This package is maintained by the PyPA, is a dependency of setuptools, and was already installed in the existing polyfun env. Thus I added it to polyfun.yml for documentation purposes, but polyfun.yml.lock doesn't need to be updated.
This is a follow up to PR #149. I updated
finemapper.py
to use the existing rpy2 code if rpy2 <3.5.9, and to use the solution from @Ojami in https://github.com/omerwe/polyfun/pull/149#issuecomment-1484110637 if rpy2 >=3.5.9.As a precaution to avoid the potential missing value bug in rpy2 3.5.7 and 3.5.8, I updated the
polyfun.yml
file to avoid these 2 versions. However, since I don't actually have any evidence that the bug will affect the polyfun code, I didn't explicitly throw an error infinemapper.py
if one of those versions is installed. In other words, I'm directing users away from these versions, but not preventing a user if they for some reason really want to install one of those versions.I compare the version strings using the 3rd party package packaging. This package is maintained by the PyPA, is a dependency of setuptools, and was already installed in the existing polyfun env. Thus I added it to
polyfun.yml
for documentation purposes, butpolyfun.yml.lock
doesn't need to be updated.xref: #153