omerwe / polyfun

PolyFun (POLYgenic FUNctionally-informed fine-mapping)
MIT License
85 stars 21 forks source link

negative weights appear in the. mixweights file without arg --allow-neg-mixweights #196

Closed Y-Isaac closed 2 months ago

Y-Isaac commented 2 months ago

HI,@omerwe

Currently I found that even if I didn't specify the --allow-neg-mixweights parameter, negative weights still appear in the .mixweights file. Can you please check it?

omerwe commented 2 months ago

@Y-Isaac thanks for flagging this. This is actually the intended behavior after the update. The reason is that sometimes the PRS itself is negatively correlated to the phenotype used for estimating mixing weight. So the mixing weight is negative with respect to PRS, but is in fact positive with respect to the flipped PRS. I realize this is somewhat incoherent, but this is how the code works at the moment.

Y-Isaac commented 2 months ago

@omerwe Thanks for explanation!