search

omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE
GNU General Public License v3.0
665 stars 57 forks source link

bug: the pop-up does not show #22

Closed technophile-04 closed 3 months ago

technophile-04 commented 8 months ago

Description :

https://github.com/omerxx/tmux-sessionx/assets/80153681/b15ad730-411d-4aab-8adc-4a6edbb9e868

For some reason, the session window does not pop open for me the screen just flickers but nothing happens :

My tmux config : https://github.com/technophile-04/tmux.conf

My wezter config : https://github.com/technophile-04/wezterm-config

I also have fzf, bat and zoxide installed through brew

Pardon me if I missed something, also thanks for creating such an awesome plugin !!

omerxx commented 2 months ago

Hi all, I'm seeing this issue. If I watch very carefully and attempt to open it repeatedly, I can see a brief glimpse inside the popup with an error message saying something like "scrollbar display width should be 1" or something to that effect. It's so fast I can't capture it.

I'm running fzf 0.38.0 (debian), with tmux 3.3a. I'm on debian linux (bookworm 12.5) with alacritty 0.11.0.

Any suggestions?

Thanks! -David

Hey @hesperaux, the issue stems from the terminal's inability to draw the scrollbar - https://github.com/omerxx/tmux-sessionx/blob/56abffd0155805f8165fb5af19c50d04c4a49069/scripts/sessionx.sh#L209C16-L209C18

I don't think this is an Alacritty issue, but, can you try running it on another emulator like Wezterm for comparison? Also, make sure the latest version of the plugin is installed. Thanks!

Edit 2 - reading FZF's code, it counts runes provided as an option, as if the scrollbar is an empty string. That said, looks like my FZF (0.46.1) can handle even an empty string (--scrollbar ""). So - can you please try upgrading FZF? I have a strong feeling this should fix the issue for you

hesperaux commented 2 months ago

@omerxx thanks for the info. I do have nerd fonts installed (0xproto nerd font).

Are you saying that the terminal should support a scroll bar, or that it doesn't matter if it does?

I started to drive into the scripts earlier but I kinda suck at bash and I'm not familiar with tmux plugin dev either. I was going to try installing fzf from git to try that but I ran out of time for the night.

omerxx commented 2 months ago

@hesperaux sorry, should have added another comment, but I edited mine. Nope, the scollbar isn't part of nerdfonts, it's a simple unicode. For whatever reason the scrollbar string fzf is getting on your env is empty, which is why I'm suggesting

  1. Make sure FZF is updated (will likely help)
  2. Make sure the plugin is updated (less likely the reason)
hesperaux commented 2 months ago

@omerxx Thank you for taking the time to help. It's working great now. I realized that I had fzf installed via git but it was not the one being used. It was obvious but I overlooked it. I had installed fzf from git and it was in my home directory bin folder, but because it had been installed by apt into /usr/bin, that path was taking precedance. The version from git is much newer (0.46.1). That took care of it. This looks like a nice plugin. Happy I can finally use it. :)