omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE
GNU General Public License v3.0
556 stars 51 forks source link

Fix rename in fish shell #55

Closed mluna-again closed 4 months ago

mluna-again commented 4 months ago

Hi, this should fix #20 The problem is that:

  1. fish's read behaves differently than bash's, it probably fails because it doesn't have access to stdin?
  2. when it sees a $ it errors because there is no variable $, I guess bash just lets you do whatever and passes the $ as is.

Anyways, fish has a lot of quirks so I don't think it's worth trying to make it work for it, just make it use bash always with bash -c ....

I tested it in fish and bash and it works as expected.

ProgmRuanSilva commented 4 months ago

Hey @mluna-again thanks for contributing

This reminds me to make a rebind key to rename command