stops removing spaces from session names

omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE

GNU General Public License v3.0

714 stars 63 forks source link

stops removing spaces from session names #57

Closed yakloinsteak closed 6 months ago

yakloinsteak commented 6 months ago

Git log research: I think the space removal came about in a commit with the message "additional input for custom paths" and effectively has been in place since that feature was added. Commit: 5107ae06e0a175d68816ff081cc186214306c064
I think the intent was to remove spaces because of a bug in additional_input. It didn't iterate over the list of options and the for loop ran once no matter what (for me at least).

I'm wondering why the additional_input method was so complicated, so maybe I'm missing something.

Fixes #38

ProgmRuanSilva commented 6 months ago

Hi @yakloinsteak thanks for contributing

I spent some time looking at this pull, but I couldn't find the error yet.

But I'll take a better look later.

ProgmRuanSilva commented 6 months ago

Okay, if I understand correctly what you want to do

The Unknown session "custom-path-name" is rendered by the preview, not in additional input.
The rename is called by using the "read" command, and it does not have the functionality to read the spaces just ","

We need to think of a way to get the custom path with a predefined name for it

yakloinsteak commented 6 months ago

I'm not sure I 100% follow, but I just pushed a commit that now lets us rename sessions with spaces. I was originally just making the sessions that already had a space in the name show up correctly (I happened to have a session called "query opt" when I installed your plugin, and it was listed as "queryopt" and I couldn't switch to it.

How does this look now? And thanks for the great plugin. It's been a great improvement to my workflow.

yakloinsteak commented 6 months ago

I've been running this fork for a while now without a problem. Is there anything you want me to change or test further?

ProgmRuanSilva commented 6 months ago

I'm not sure I 100% follow, but I just pushed a commit that now lets us rename sessions with spaces. I was originally just making the sessions that already had a space in the name show up correctly (I happened to have a session called "query opt" when I installed your plugin, and it was listed as "queryopt" and I couldn't switch to it.

How does this look now? And thanks for the great plugin. It's been a great improvement to my workflow.

Understood

like this:

Okay, this is cool thanks for contributing @yakloinsteak

Can you solve the conflict to merge it?

yakloinsteak commented 6 months ago

@ProgmRuanSilva I fixed the merge conflict and retested things.