omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE
GNU General Public License v3.0
556 stars 51 forks source link

Error when showing sessionx window #63

Closed mayersj1 closed 3 months ago

mayersj1 commented 3 months ago

Something in the slew of changes merged on 3/21 has broken tmux-sessionx for me. Now, when the sessionx window comes up, it gives me this error in the preview window: "can't find window: 1zsh"

The window name is "1 zsh" (notice the space). If I rename the window (:rename-window Foobar) the window becomes "1 Foobar" and bringing up sessionx reports the error "can't find window: 1Foobar"

The standard, built-in session manager works just fine still.

mayersj1 commented 3 months ago

I believe this is related to https://github.com/omerxx/tmux-sessionx/pull/61

mayersj1 commented 3 months ago

CleanShot 2024-03-22 at 10 53 28@2x

mayersj1 commented 3 months ago

More info. If I'm in the sessionx pane and I execute the 'alt-s' to go into window mode, I get the previews and the list shown now drops the window name and only shows the window id.

CleanShot 2024-03-22 at 11 17 34@2x

mayersj1 commented 3 months ago

If when in the sessionx pane, I choose alt-w to go into tree mode, I get the following:

CleanShot 2024-03-22 at 11 18 19@2x

NOTE: See that the window names are now back in the list with no space between the ID and the name

mayersj1 commented 3 months ago

Changing line 196 of sessionx.sh back to

RESULT=$(echo -e "${INPUT}" | fzf-tmux "${fzf_opts[@]}" "${args[@]}")

Seems to have resolved the issue for me.

I do see one other oddity though and that's now when I'm in the sessionx pane, and I'm highlighting a session, if I'm not in that session, alt-x (to delete the session) doesn't work. It simply highlights that session (removing all others from the screen) and then I'm able to hit alt-x again to remove that session. Then the other session info appears.

mayersj1 commented 3 months ago

Looks like Adreas' fix from commit ID c8aab6e557a50683e9ec804e5d67d8685a44d7a1 was reverted when you did your patches Ruan.

ProgmRuanSilva commented 3 months ago

Sorry, this was fixed on #65