omerxx / tmux-sessionx

A Tmux session manager, with preview, fuzzy finding, and MORE
GNU General Public License v3.0
718 stars 63 forks source link

Ubuntu 22 LTS - fzf-tmux error: `unknown option: --border-label` #9

Closed TechDufus closed 9 months ago

TechDufus commented 9 months ago

I'm not sure if this is a difference in fzf-tmux versions installed via apt vs homebrew or otherwise, but I've installed fzf via apt on Ubuntu 22 LTS and the latest version that I can install currently is fzf 0.29.0-1

fzf --version
0.29 (devel)
fzf-tmux --version
fzf-tmux (with fzf 0.29 (devel))

If I manually go into my locally installed plugin and remove this line then this all works (as for as I've briefly tested) on Ubuntu.

https://github.com/omerxx/tmux-sessionx/blob/d71e51b4be2e94ca5d92f5f8afcc190ac56980f1/scripts/sessionx.sh#L48

omerxx commented 9 months ago

Hmmm. I wonder whether it's worth to remove all together or add a config variable specific for fzf devel. WDYT?

omerxx commented 9 months ago

@TechDufus Any chance this is a 2 years old fzf release (https://github.com/junegunn/fzf/releases/tag/0.29.0)? Care to upgrade and check again?

TechDufus commented 9 months ago

Let me build out my dotfiles to dynamically get the latest github release for fzf instead of relying on apt packages and see if that works... :) Please hold.

TechDufus commented 9 months ago

✅ Good to go... I'm no longer installing fzf via apt. I'm following their git instructions to clone and run their install script.

I use ansible for my dotfiles, so that's how I'm cloning and installing.

https://github.com/TechDufus/dotfiles/blob/5b3c2eeabc3a377a543da3e69b2d0baeb719ebdd/roles/fzf/tasks/ubuntu.yml#L2-L11

omerxx commented 9 months ago

Closing. If anything changes let me know