search

omeryusufyagci / fast-music-remover

A C++ based, lightweight music and noise remover for YouTube and other internet media, using DeepFilterNet for audio enhancement.
MIT License
163 stars 20 forks source link

Improvement: Backend Improvements for Typing, Tests, Modularity and Pathlib #39

Closed wenayy closed 1 month ago

wenayy commented 1 month ago

added all the functionality you can check it Typing: Add type hints throughout the backend Unit Tests: Develop unit tests for all utility and processing functions. Response Handling: Add a ResponseHandler class in backend/response_handler.py to handle all communication bwn BE-FE, BE-core using consistent JSON responses. Replace os with pathlib Reorganize the code under backend/: Move Utils to backend/utils.py Move MediaHandler to backend/media_handler.py Keep app.py for route definitions and Flask app initialization.

omeryusufyagci commented 1 month ago

Thanks for your second PR to this project, but unfortunately, it does not meet the project requirements. The current code is not functional, and there are commits outside the scope of this PR. Additionally, the unit tests were either minimal or not tests at all, but rather the class itself.

Thank you for your understanding, and I hope to see improved contributions in the future.