search

omeryusufyagci / fast-music-remover

A C++ based, lightweight music and noise remover for YouTube and other internet media, using DeepFilterNet for audio enhancement.
MIT License
162 stars 20 forks source link

Feature: Add DeepFilterCommandBuilder to MediaProcessor #42

Closed georgeolson92 closed 1 month ago

georgeolson92 commented 1 month ago

This is my first time working in the code base (and with anything related to deep filtering), hope this will address the new feature implementation in issue #32! Let me know what needs to be adjusted, or if there is anything else I should add!

georgeolson92 commented 1 month ago

Made updates based on recommendations from review, let me know how everything looks! Thank you for all of the helpful feedback!

georgeolson92 commented 1 month ago

Thanks for the review, made requested updates and ran clang-format, let me know how it's looking!

georgeolson92 commented 3 weeks ago

Hi @omeryusufyagci, I can certainly continue working on the Deep Filter classes, if you have any issues open feel free to assign me and I can create a new branch for that!

omeryusufyagci commented 3 weeks ago

Hi @georgeolson92, fantastic to hear! : ) We have #65, and #52 that are DeepFilter specific. I am not able to assign you directly -for some reason can't find you on the list. If you could leave a comment on these I can assign them to you.

As usual, I am happy to clarify anything that may come as we progress.

Thanks a lot!