codepathreview
commented
8 years ago Good job at completing all required stories & few optionals. A few notes after checking out the code:
- Properly sent and received relevant filters using a bundle to pass data between activities
- Properly used spinners to allow users to select filters
- Good effort at polishing the UI and adding the modal overlay
- Good job adding the share intent
- Your attempt to improve performance using the ViewHolder pattern was noted.
- Good job using Parcelable instead of Serializable (benefits)
- Good job moving the search field into the SearchView
- Consider adding progress bars to your app whenever a network request goes out
- Nice work adding the check to see if network is available.
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
My project is now ready for review, @codepathreview @codepath.
Thank you again for the few extra hours to complete this!