search

omf2097 / openomf

One Must Fall 2097 Remake
http://www.openomf.org
MIT License
362 stars 35 forks source link

SDL 2.0.6 audio issues on windows #346

Closed katajakasa closed 6 years ago

katajakasa commented 6 years ago

On windows, audio playback suggers from clicks and popping. Can be fixed by using directsound backend. See https://discourse.libsdl.org/t/sdl-hint-audio-resampling-mode/23196 for more details.

Should we check SDL version string and set directsound if 2.0.6 found ? Looks like 2.0.7 is going to be pushed out fast with bugfixes :/

Vagabond commented 6 years ago

When, on windows, would you NOT want to use directsound?

katajakasa commented 6 years ago

Directsound is deprecated. The api of choice nowadays is WASAPI (which the SDL2 tries to use). At least on newer windows versions, dsound can be somewhat problematic.

katajakasa commented 6 years ago

SDL 2.0.7 fixed everything. Since 2.0.6 did not have much time to live and looks like 2.0.7 has pretty much replaced it everywhere, I think we can just close this. No 2.0.6 specific hacks required.