search

omg-dds / dds-rtps

Validation of interoperability of products compliant with OMG DDS-RTPS standard.
https://www.omg.org/spec/DDSI-RTPS/
Other
11 stars 17 forks source link

Adding new tests #19

Closed angelrti closed 2 months ago

angelrti commented 2 months ago

This PR fixes some previous tests that were not working as expected and also adds some new tests.

This modifies the CPP code, so a new executable needs to be generated after merging the PR. This will lead to the creation of a new release.

I'll be merging this PR by Feb 29th, so please, add your feedback before that date.

mitza-oci commented 2 months ago

I tried building this branch with OpenDDS. There are warnings in shape_main.cxx that should be common to all DDS implementations. This is from GCC 11.4

/home/mitza/dds-rtps/srcCxx/shape_main.cxx:533:37: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
  533 |                 if (write_period_us < 0) {
      |                     ~~~~~~~~~~~~~~~~^~~
/home/mitza/dds-rtps/srcCxx/shape_main.cxx:551:36: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
  551 |                 if (read_period_us < 0) {
      |                     ~~~~~~~~~~~~~~~^~~
/home/mitza/dds-rtps/srcCxx/shape_main.cxx:390:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
  390 |             if (optarg[0] != '\0') {
      |             ^~
/home/mitza/dds-rtps/srcCxx/shape_main.cxx:412:13: note: here
  412 |             case 'i': {
      |             ^~~~