changes to facilitate test automation (similar to dds-rtps)

ClarkTucker commented 4 months ago

This changes the output of the test binary so that it more closely matches the output messages of the dds-rtps test.

I copied the 'logger' class from dds-rtps.
I added some calls to the logger to output ERRORS and DEBUG messages, similar to those in dds-rtps.
I added a DomainParticipantListener to print out messages on most events (publication matched, incompatible qos, etc). [This change may be 'vendor specific', and is added in the 'configurator' header file. Other vendors will have to do something similar...]
Publishing rate is adjusted from 1/sec to 10/second.
The output generated from each received sample is condensed onto one line.

mitza-oci commented 4 months ago

Would it be more maintainable for us to have the dds-security test code in the dds-rtps repository instead of this separate repo?

colmenero commented 4 months ago

Would it be more maintainable for us to have the dds-security test code in the dds-rtps repository instead of this separate repo?

@mitza-oci Is it a question of organization? That is, moving the current code into the other repository. Reuse functionality required by both (like the logger that this PR adds).

Or is it a question of trying to unify code? Ideally the same tests could be configure to run with/without security. This would be more difficult, from what I see the repositories have diverged quite much.

Maybe we could open a separate discussion (as an issue?) to agree on this without "polluting" this PR. What do you think @ClarkTucker?

ClarkTucker commented 4 months ago

Would it be more maintainable for us to have the dds-security test code in the dds-rtps repository instead of this separate repo?

@mitza-oci Is it a question of organization? That is, moving the current code into the other repository. Reuse functionality required by both (like the logger that this PR adds).

Or is it a question of trying to unify code? Ideally the same tests could be configure to run with/without security. This would be more difficult, from what I see the repositories have diverged quite much.

Maybe we could open a separate discussion (as an issue?) to agree on this without "polluting" this PR. What do you think @ClarkTucker?

I think it makes sense to consider merging them. But, right now, I'm on the fence:

I think the two testing scenarios are very different [very different test parameters in each repo]; BUT
the automation framework will be fairly similar

So, it's not clear to me which way will be easier in the long-term.

Bottom-line: I like the idea of discussing it further in a separate issue.

colmenero commented 4 months ago

@ClarkTucker I can run the rti executable and see the same output! So that's great.

I'm not approving yet, because I'd like to do a last review when I get back from a few days of PTO. I hope there is no hurry for this. It would have been merged into feature/DH anyway and I won't be able to continue with it until then.

ClarkTucker commented 4 months ago

@ClarkTucker I can run the rti executable and see the same output! So that's great.

I'm not approving yet, because I'd like to do a last review when I get back from a few days of PTO. I hope there is no hurry for this. It would have been merged into feature/DH anyway and I won't be able to continue with it until then.

No problem! Thanks for looking at it, and enjoy your break!

omg-dds / dds-security

changes to facilitate test automation (similar to dds-rtps) #17