omg-dmn-taskforce / omg-dmn-spec

OMG Decision Model and Notation specification
https://www.omg.org/spec/DMN/
12 stars 9 forks source link

DMN14-190/DMN14-191/DMN14-192/DMN14-193/DMN14-194/DMN14-195 Changes to the diagrams for conditional, filter and iterator boxed expression #17

Closed SimonRinguette closed 2 years ago

SimonRinguette commented 3 years ago

Related to XSD changes #14, #15 & #16 MM change #18

falko commented 2 years ago

Approved in Ballot 5

falko commented 2 years ago

@SimonRinguette after discusing and reviewing DMN14-195 with Michelle, I noticed that the proposal text also mentioned adding the following to Figure 10.17 Expression class diagram:

Add the following abstract class extending Expression Iterator
+iteratorVariable: String
Add the following class extending Iterator For
Add the following abstract class extending Iterator Quantified
Add the following class extending Quantified Every
Add the following class extending Quantified Some
Add the following class ChildExpression
+id: ID [0..1]
Add the following class extending ChildExpression TypedChildExpression
+typeRef: String [0..1]

Create one aggregation between ChildExpression and Expression named value with a cardinality of 1.

Create an aggregation between Iterator and the new TypedChildExpression class named “in” with a cardinality of 1.

Create an aggregation between For and ChildExpression named return with a cardinality of 1.

Create an aggregation between Quantified and ChildExpression named satisfies with a cardinality of 1.

However the only addition to the diagram seems to be the class Iterator:

Am I missing something or should I raise this as an issue to complete the diagram in DMN 1.5?

falko commented 2 years ago

@sringuette any feedback regarding this?

SimonRinguette commented 2 years ago

In the metamodel, (magic draw) i've created an ExpressionL4 diagram with these details:

image

However, when doing the actual change, these details were not appropriate for the L3 diagram and would not fit on the real estate we had.

If we want these details in the diagram, you can raise an issue to have that diagram integrated in 1.5

falko commented 2 years ago

We discussed it in today's RTF meeting and are going to raise an issue to add the diagram in DMN 1.5 as you suggested.