search

omgnetwork / elixir-omg

OMG-Network repository of Watcher and Watcher Info
https://omg.network
Apache License 2.0
213 stars 59 forks source link

EXIT_PROCESSOR_SLA_SECONDS instead of EXIT_PROCESSOR_SLA_MARGIN #1399

Open unnawut opened 4 years ago

unnawut commented 4 years ago

Overview

Currently EXIT_PROCESSOR_SLA_MARGIN is in number of blocks while EXIT_PERIOD_SECONDS is in seconds. This is prone to misunderstanding.

Ino 22 hours ago can we unify EXIT_PROCESSOR_SLA_MARGIN into seconds?

Ino 22 hours ago I’m afraid this is prone to a mistake

piotr 22 hours ago move to seconds could be a good move (consistent with block time & exit period settings, as opposed to other margins), however might require some legwork

Suggestion is to replace EXIT_PROCESSOR_SLA_MARGIN with EXIT_PROCESSOR_SLA_SECONDS

souradeep-das commented 4 years ago

What values do we do for EXIT_PROCESSOR_SLA_SECONDS for docker-compose

unnawut commented 4 years ago

So as discussed earlier we should be able to derive from EXIT_PROCESSOR_SLA_MARGIN and ETHEREUM_BLOCK_TIME_SECONDS.

Also might be worth using EXIT_PROCESSOR_SLA_MS to have the same time unit as most other configs.

unnawut commented 4 years ago

cc'ing @kevsul if I missed any other conversations on this one!

souradeep-das commented 4 years ago

But isn't MIN_EXIT_PERIOD_SECONDS in seconds ?