feat: store fees on transaction insert

omgnetwork / omg-childchain-v2

pronounced /Ch-ch/

Apache License 2.0

5 stars 2 forks source link

feat: store fees on transaction insert #158

Closed pgebal closed 3 years ago

pgebal commented 3 years ago

Closes: https://github.com/omgnetwork/childchain/issues/156 Changes:

when inserting transactions paid fees are inserted into the db

Performance of Transaction.insert is about the same as currently in master.

pgebal commented 3 years ago

There's a many 2 many relationship between transactions and transaction fees. Can you point me to a test that covers that?

There is one to many relationship, and test is called "inserts paid fees" in transaction_test.exs. If you think it's needed I can clearly test for 1 transaction -> 2 fees relationship