Introduce amount validation based on transaction type - Githubissues

omgnetwork / omg-childchain-v2

pronounced /Ch-ch/

Apache License 2.0

5 stars 2 forks source link

Introduce amount validation based on transaction type #57

Closed mederic-p closed 4 years ago

mederic-p commented 4 years ago

Closes https://github.com/omisego/childchain/issues/47

This PR refactors transaction validation into split modules and introduce amount validation for payment transaction.

Note that the fees are not handled for now and we just pass :no_fees_required. They will need to be loaded and formatted.

Also, a few other things that are NOT handled but should be:

detect merge transaction and set fees to :no_fees_required
input ownership
inputs not spent
inputs not from future blocks
fee claiming