omgnetwork / omg-childchain-v2

pronounced /Ch-ch/

Apache License 2.0

5 stars 2 forks source link

Add fees #90

Closed ayrat555 closed 4 years ago

ayrat555 commented 4 years ago

Resolves https://github.com/omgnetwork/childchain/issues/50

mederic-p commented 4 years ago

Was about to suggest what Ino said, I agree that it'd be easier to split this PR, also worth checking what to keep and what to simplify from elixir-omg. Regarding the API, https://github.com/omgnetwork/childchain/pull/94 will introduce some refactoring so it may be good for you to wait until it's merged before working on it.

InoMurko commented 4 years ago

Also, the way fees are gonna work in terms of having multiple childchains nodes needs to be addressed for consistency. So from that perspective, it's easier what we can use and what problems we need to solve again but differently.

ayrat555 commented 4 years ago

@InoMurko @mederic-p I separated this PR into: https://github.com/omgnetwork/childchain/pull/95 https://github.com/omgnetwork/childchain/pull/96 https://github.com/omgnetwork/childchain/pull/97 https://github.com/omgnetwork/childchain/pull/98