search

omgnetwork / omgnetwork.github.io

Developer Portal for OMG Network
https://docs.omg.network/
1 stars 3 forks source link

Administrative controls for smart contracts #92

Closed thec00n closed 4 years ago

thec00n commented 4 years ago

Closes https://github.com/omgnetwork/omgnetwork.github.io/issues/90

deeintech commented 4 years ago

why there is 2 version of mostly the same stuff??

That's how Docusaurus keeps versioning. There's the main folder /docs where all docs are stored + /website/versioned_docs/version for different versions.

boolafish commented 4 years ago

@dmitrydao then a n00bie question, what contents should be in the /docs and what should belongs to versioned_docs/version

I do sense there are slight different in this PR. Is there a guide on this?

thec00n commented 4 years ago

@boolafish good catch. There were some differences between the 2 pages (It's easy to forget about it, @dmitrydao maybe we can add some automation to at least check that pairs are the same?). I also made some minor edits to function descriptions.

deeintech commented 4 years ago

@boolafish good catch. There were some differences between the 2 pages (It's easy to forget about it, @dmitrydao maybe we can add some automation to at least check that pairs are the same?). I also made some minor edits to function descriptions.

Yeah, I was thinking about automating this somehow. Didn't have the time for it yet.

deeintech commented 4 years ago

ah...okay so the two page should be the same. LGTM then

Yeah, the content should be the same, the header has a bit different naming for versioned docs. I have this described in the README + CONTRIBUTING files of this repo.