search

omgnetwork / optimism-v2

ARCHIVE of monorepo implementing Boba, an L2 Compute solution built on Optimistic Ethereum - active repo is at https://github.com/bobanetwork/boba
https://github.com/bobanetwork/boba
MIT License
40 stars 22 forks source link

[L2Geth] Add reverted reason in the returned payload #433

Closed boyuan-chen closed 2 years ago

boyuan-chen commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #433 (9a15e9d) into develop (09fa220) will increase coverage by 0.60%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
+ Coverage    73.00%   73.61%   +0.60%     
===========================================
  Files           57       59       +2     
  Lines         1682     1789     +107     
  Branches       259      272      +13     
===========================================
+ Hits          1228     1317      +89     
- Misses         454      472      +18
Flag Coverage Δ
contracts 87.18% <ø> (ø)
core-utils 53.79% <ø> (ø)
data-transport-layer 32.91% <ø> (ø)
message-relayer 83.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/message-relayer/src/relay-tx.ts 82.52% <0.00%> (ø)
packages/message-relayer/hardhat.config.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09fa220...9a15e9d. Read the comment docs.

boyuan-chen commented 2 years ago

The revert reason should come from the helper contract instead of l2geth.