Closed souradeep-das closed 2 years ago
Merging #470 (d3e2d54) into develop (14cefb2) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #470 +/- ##
========================================
Coverage 72.10% 72.10%
========================================
Files 59 59
Lines 1828 1828
Branches 281 281
========================================
Hits 1318 1318
Misses 510 510
Flag | Coverage Δ | |
---|---|---|
contracts | 86.72% <ø> (ø) |
|
core-utils | 53.79% <ø> (ø) |
|
data-transport-layer | 29.25% <ø> (ø) |
|
message-relayer | 83.17% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 14cefb2...d3e2d54. Read the comment docs.
Can we remove the build folder? Also, we need to mention that developers have to contact us to add the pairs in the NFT bridges. It will be nice if we can add the script to allow them to directly test on Rinkeby, so they don't have to spend a day figuring out how to spin up the local stack. The fraud proof window of Rinkeby is 5 mins, so they can exit their NFT from L2 quickly.
Can we remove the build folder? Also, we need to mention that developers have to contact us to add the pairs in the NFT bridges. It will be nice if we can add the script to allow them to directly test on Rinkeby, so they don't have to spend a day to figure out how to spin up the local stack. The fraud proof window of Rinkeby is 5 mins, so they can exit their NFT from L2 quickly.
Yes, @souradeep-das please add that
sure, reiterating the pair registration part, yeah the only reason the dependency on local stack is to have the essence of using your own contracts (because of the registration part), but nice idea, will add an optional quickstart on rinkeby for people, which can work with pre-deployed preset contracts
moved to /bobanetwork