search

omgnetwork / plasma-cash

122 stars 34 forks source link

Add key to client #89

Closed bun919tw closed 6 years ago

bun919tw commented 6 years ago

Currently client will only have one instance in the whole process. However, client should be changed to be stateful due to future db implementation. Therefore, add one variable named key to client constructor indicating the owner of the client.

codecov-io commented 6 years ago

Codecov Report

Merging #89 into master will increase coverage by 0.76%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage    84.2%   84.96%   +0.76%     
==========================================
  Files          22       22              
  Lines         538      532       -6     
  Branches       51       50       -1     
==========================================
- Hits          453      452       -1     
+ Misses         83       78       -5     
  Partials        2        2
Impacted Files Coverage Δ
plasma_cash/dependency_config.py 45.23% <ø> (+2.38%) :arrow_up:
plasma_cash/client/client.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 201cc5c...046d0c6. Read the comment docs.

bun919tw commented 6 years ago

@boolafish I have

  1. Added one property named address in the client.
  2. Changed the key to a real one in client unit test.
bun919tw commented 6 years ago

@boolafish Thanks for the review. I've removed the dummy address in client unit tests and I also changed the title of this PR and commit. Merge this PR by myself.