search

omgnetwork / plasma-contracts

Root chain contracts for Plasma
Apache License 2.0
112 stars 66 forks source link

truffle deploy contracts in integration_949_elixir_omg_pr #326

Closed InoMurko closed 5 years ago

InoMurko commented 5 years ago

Issue Type

[ ] bug report
[ x] feature request

Current Behavior

Deploys old contract behaviour.

plasma-deployer_1  | - Fetching solc version list from solc-bin. Attempt #1
plasma-deployer_1  | - Downloading compiler. Attempt #1
plasma-deployer_1  | - Blocks: 0            Seconds: 0
plasma-deployer_1  | - Saving migration to chain.
plasma-deployer_1  | - Blocks: 0            Seconds: 0
plasma-deployer_1  | - Blocks: 0            Seconds: 0
plasma-deployer_1  | - Blocks: 0            Seconds: 0
plasma-deployer_1  | - Saving migration to chain.
plasma-deployer_1  | - Saving migration to chain.
plasma-deployer_1  | - Saving migration to chain.
plasma-deployer_1  | {"\nCompiling your contracts...\n===========================\n> Compiling ./contracts/BasicToken.sol\n> Compiling ./contracts/Bits.sol\n> Compiling ./contracts/ByteUtils.sol\n> Compiling ./contracts/ECRecovery.sol\n> Compiling ./contracts/ERC20.sol\n> Compiling ./contracts/ERC20Basic.sol\n> Compiling ./contracts/Eip712StructHash.sol\n> Compiling ./contracts/Math.sol\n> Compiling ./contracts/Merkle.sol\n> Compiling ./contracts/Migrations.sol\n> Compiling ./contracts/MintableToken.sol\n> Compiling ./contracts/Ownable.sol\n> Compiling ./contracts/PlasmaCore.sol\n> Compiling ./contracts/PlasmaCoreTest.sol\n> Compiling ./contracts/PriorityQueue.sol\n> Compiling ./contracts/PriorityQueueFactory.sol\n> Compiling ./contracts/PriorityQueueLib.sol\n> Compiling ./contracts/PriorityQueueWrapper.sol\n> Compiling ./contracts/RLP.sol\n> Compiling ./contracts/RLPTest.sol\n> Compiling ./contracts/RootChain.sol\n> Compiling ./contracts/SafeMath.sol\n> Compiling ./contracts/SignatureTest.sol\n> Compiling ./contracts/StandardToken.sol\n\n    > compilation warnings encountered:\n\n/opt/plasma_deployer/contracts/Ownable.sol:20:3: Warning: Defining constructors as functions with the same name as the contract is deprecated. Use \"constructor(...) { ... }\" instead.\n  function Ownable() {\n  ^ (Relevant source part starts here and spans across multiple lines).\n,/opt/plasma_deployer/contracts/RLPTest.sol:16:9: Warning: Use of the \"var\" keyword is deprecated.\n        var txList = RLP.toList(RLP.toRLPItem(tx_bytes));\n        ^--------^\n,/opt/plasma_deployer/contracts/RLPTest.sol:29:9: Warning: Use of the \"var\" keyword is deprecated.\n        var txList = RLP.toList(RLP.toRLPItem(tx_bytes));\n        ^--------^\n,/opt/plasma_deployer/contracts/BasicToken.sol:29:5: Warning: Invoking events without \"emit\" prefix is deprecated.\n    Transfer(msg.sender, _to, _value);\n    ^-------------------------------^\n,/opt/plasma_deployer/contracts/RLP.sol:596:17: Warning: The use of labels is deprecated. Please use \"if\", \"switch\", \"for\" or function calls instead.\n                tag_loop:\n                ^------^\n,/opt/plasma_deployer/contracts/RLP.sol:596:17: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using \"switch\", \"if\" or \"for\" statements instead.\n                tag_loop:\n                ^------^\n,/opt/plasma_deployer/contracts/RLP.sol:597:21: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using \"switch\", \"if\" or \"for\" statements instead.\n                    jumpi(end, eq(i, words))\n                    ^----------------------^\n,/opt/plasma_deployer/contracts/RLP.sol:603:21: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using \"switch\", \"if\" or \"for\" statements instead.\n                    jump(tag_loop)\n                    ^------------^\n,/opt/plasma_deployer/contracts/RLP.sol:604:17: Warning: The use of labels is deprecated. Please use \"if\", \"switch\", \"for\" or function calls instead.\n                end:\n                ^-^\n,/opt/plasma_deployer/contracts/RLP.sol:604:17: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using \"switch\", \"if\" or \"for\" statements instead.\n                end:\n                ^-^\n,/opt/plasma_deployer/contracts/Eip712StructHash.sol:24:41: Warning: Initial value for constant variable has to be compile-time constant. This will fail to compile with the next breaking version change.\n    bytes32 constant DOMAIN_SEPARATOR = keccak256(abi.encode(\n                                        ^ (Relevant source part starts here and spans across multiple lines).\n,/opt/plasma_deployer/contracts/StandardToken.sol:34:5: Warning: Invoking events without \"emit\" prefix is deprecated.\n    Transfer(_from, _to, _value);\n    ^---------------------" <> ...,
plasma-deployer_1  |  0}
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.071 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  Compiling your contracts...
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  ===========================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/BasicToken.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/Bits.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/ByteUtils.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/ECRecovery.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/ERC20.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/ERC20Basic.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/Eip712StructHash.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.074 [info]  > Compiling ./contracts/Math.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.075 [info]  > Compiling ./contracts/Merkle.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.075 [info]  > Compiling ./contracts/Migrations.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.075 [info]  > Compiling ./contracts/MintableToken.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.075 [info]  > Compiling ./contracts/Ownable.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.076 [info]  > Compiling ./contracts/PlasmaCore.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.076 [info]  > Compiling ./contracts/PlasmaCoreTest.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/PriorityQueue.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/PriorityQueueFactory.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/PriorityQueueLib.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/PriorityQueueWrapper.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/RLP.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/RLPTest.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/RootChain.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/SafeMath.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.077 [info]  > Compiling ./contracts/SignatureTest.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  > Compiling ./contracts/StandardToken.sol
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]      > compilation warnings encountered:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  /opt/plasma_deployer/contracts/Ownable.sol:20:3: Warning: Defining constructors as functions with the same name as the contract is deprecated. Use "constructor(...) { ... }" instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]    function Ownable() {
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]    ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  ,/opt/plasma_deployer/contracts/RLPTest.sol:16:9: Warning: Use of the "var" keyword is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]          var txList = RLP.toList(RLP.toRLPItem(tx_bytes));
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]          ^--------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  ,/opt/plasma_deployer/contracts/RLPTest.sol:29:9: Warning: Use of the "var" keyword is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]          var txList = RLP.toList(RLP.toRLPItem(tx_bytes));
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]          ^--------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  ,/opt/plasma_deployer/contracts/BasicToken.sol:29:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]      Transfer(msg.sender, _to, _value);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]      ^-------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:596:17: Warning: The use of labels is deprecated. Please use "if", "switch", "for" or function calls instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]                  tag_loop:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]                  ^------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:596:17: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch", "if" or "for" statements instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]                  tag_loop:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.083 [info]                  ^------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:597:21: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch", "if" or "for" statements instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                      jumpi(end, eq(i, words))
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                      ^----------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:603:21: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch", "if" or "for" statements instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                      jump(tag_loop)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                      ^------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:604:17: Warning: The use of labels is deprecated. Please use "if", "switch", "for" or function calls instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                  end:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                  ^-^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:604:17: Warning: Jump instructions and labels are low-level EVM features that can lead to incorrect stack access. Because of that they are discouraged. Please consider using "switch", "if" or "for" statements instead.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                  end:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                  ^-^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/Eip712StructHash.sol:24:41: Warning: Initial value for constant variable has to be compile-time constant. This will fail to compile with the next breaking version change.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]      bytes32 constant DOMAIN_SEPARATOR = keccak256(abi.encode(
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]                                          ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]  ,/opt/plasma_deployer/contracts/StandardToken.sol:34:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]      Transfer(_from, _to, _value);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.084 [info]      ^--------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.085 [info]  ,/opt/plasma_deployer/contracts/StandardToken.sol:50:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.085 [info]      Approval(msg.sender, _spender, _value);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.089 [info]      ^------------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]  ,/opt/plasma_deployer/contracts/StandardToken.sol:72:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      Approval(msg.sender, _spender, allowed[msg.sender][_spender]);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      ^-----------------------------------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]  ,/opt/plasma_deployer/contracts/StandardToken.sol:83:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      Approval(msg.sender, _spender, allowed[msg.sender][_spender]);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      ^-----------------------------------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]  ,/opt/plasma_deployer/contracts/Ownable.sol:40:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      OwnershipTransferred(owner, newOwner);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]      ^-----------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.090 [info]  ,/opt/plasma_deployer/contracts/MintableToken.sol:37:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      Mint(_to, _amount);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^----------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/MintableToken.sol:38:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      Transfer(address(0), _to, _amount);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^--------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/MintableToken.sol:48:5: Warning: Invoking events without "emit" prefix is deprecated.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      MintFinished();
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:877:39: Warning: This function only accepts a single "bytes" argument. Please use "abi.encodePacked(...)" or a similar function to encode the data.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]          return _computeStandardExitId(keccak256(feeExitNum), 0);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]                                        ^-------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:877:39: Warning: The provided argument of type uint256 is not implicitly convertible to expected type bytes memory.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]          return _computeStandardExitId(keccak256(feeExitNum), 0);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]                                        ^-------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/Ownable.sol:20:3: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]    function Ownable() {
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]    ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueLib.sol:32:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      function init(Queue storage self, address _owner)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueLib.sol:39:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      function insert(Queue storage self, uint256 k)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueLib.sol:46:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      function minChild(Queue storage self, uint256 i)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueLib.sol:69:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      function delMin(Queue storage self)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.091 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueFactory.sol:10:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.092 [info]      function deploy(address _forOwner)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.092 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.092 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1125:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.092 [info]      function getInFlightExitPriority(bytes _tx, uint256 _txoPos)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1400:5: Warning: No visibility specified. Defaulting to "public".
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      function _initOperator()
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]  ,/opt/plasma_deployer/contracts/PlasmaCore.sol:54:5: Warning: Function state mutability can be restricted to pure
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      function decode(bytes memory _tx)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]  ,/opt/plasma_deployer/contracts/PriorityQueueLib.sol:25:5: Warning: Function state mutability can be restricted to view
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      function isOwner(Queue storage self)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:597:21: Warning: Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]                      jumpi(end, eq(i, words))
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]                      ^----------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.093 [info]  ,/opt/plasma_deployer/contracts/RLP.sol:603:21: Warning: Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]                      jump(tag_loop)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]                      ^------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]  ,/opt/plasma_deployer/contracts/RLPTest.sol:11:5: Warning: Function state mutability can be restricted to pure
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]      function eight(bytes tx_bytes)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]  ,/opt/plasma_deployer/contracts/RLPTest.sol:24:5: Warning: Function state mutability can be restricted to pure
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.094 [info]      function eleven(bytes tx_bytes)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:865:13: Warning: Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]          if (_isDeposit(_utxoPos.getBlknum())){
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]              ^------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1075:13: Warning: Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]          if (_isDeposit(blknum)) {
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]              ^----------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1278:29: Warning: Function declared as view, but this expression (potentially) modifies the state and thus requires non-payable (the default) or payable.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]          already_finalized = _cleanupDoubleSpendingStandardExits(inputUtxoPos, _inputTx);
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]                              ^---------------------------------------------------------^
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1359:5: Warning: Function state mutability can be restricted to view
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]      function _shouldClearInFlightExit(InFlightExit storage _inFlightExit)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]  ,/opt/plasma_deployer/contracts/RootChain.sol:1390:5: Warning: Function state mutability can be restricted to pure
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]      function _isDeposit(uint256 blknum)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.106 [info]      ^ (Relevant source part starts here and spans across multiple lines).
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.107 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.107 [info]  > Artifacts written to /opt/plasma_deployer/build/contracts
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.109 [info]  > Compiled successfully using:
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.109 [info]     - solc: 0.4.25+commit.59dbf8f1.Emscripten.clang
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.109 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.109 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.109 [info]  Starting migrations...
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.110 [info]  ======================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.110 [info]  > Network name:    'local'
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.110 [info]  > Network id:      1337
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.111 [info]  > Block gas limit: 0x7270e0
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.111 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.111 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.111 [info]  1_check_authority_address.js
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.111 [info]  ============================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.116 [info]  Funding authority address 0x2b89590CDBe7117F457891E0C19845cF447fd78a
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.116 [info]  Successfully funded authority address.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     -------------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > Total cost:                   0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]  2_initial_migration.js
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]  ======================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     Deploying 'Migrations'
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     ----------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > transaction hash:    0x1689ea5e4a78f686b8f9acc2555996afac901489478e362bcc6016b07e3e1261
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > Blocks: 0            Seconds: 0
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > contract address:    0x6F13Ad87e0e2dA9E40aBfd751d115400FF728771
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > block number:        1000
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > block timestamp:     1569952346
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > account:             0xF7527026CEf1042f59301D151e9B87398b87d482
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > balance:             115792089237316195423570985008687907853269984665640564039154.598408773129639927
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > gas used:            193323
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > gas price:           20 gwei
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > value sent:          0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > total cost:          0.00386646 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > Saving migration to chain.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > Saving artifacts
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     -------------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]     > Total cost:          0.00386646 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.118 [info]  3_deploy_contracts.js
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]  =====================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     Deploying 'PriorityQueueLib'
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     ----------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > transaction hash:    0x4e696ed130bf3c4fb356b9a934969f30f413f48d1bf8cba6781b0df9ad131590
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > Blocks: 0            Seconds: 0
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > contract address:    0x7cF62bEeB565A9626c407661F4BF8476c43A9e68
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > block number:        1004
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > block timestamp:     1569952350
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > account:             0xF7527026CEf1042f59301D151e9B87398b87d482
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > balance:             115792089237316195423570985008687907853269984665640564039154.598408773129639927
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > gas used:            460069
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.119 [info]     > gas price:           20 gwei
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > value sent:          0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > total cost:          0.00920138 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     Linking
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     -------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     * Contract: PriorityQueueFactory <--> Library: PriorityQueueLib (at address: 0x7cF62bEeB565A9626c407661F4BF8476c43A9e68)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     Deploying 'PriorityQueueFactory'
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     --------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > transaction hash:    0x21f7d23b508f529efaaaa5052d5b43d796ebc92f6ea9d71365ea0898ca0310a9
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > Blocks: 0            Seconds: 0
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > contract address:    0xe7CD38fE96A4D1A72856199a62752C585EAdF566
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > block number:        1006
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > block timestamp:     1569952352
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > account:             0xF7527026CEf1042f59301D151e9B87398b87d482
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > balance:             115792089237316195423570985008687907853269984665640564039154.598408773129639927
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > gas used:            379282
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > gas price:           20 gwei
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > value sent:          0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > total cost:          0.00758564 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     Linking
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     -------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     * Contract: RootChain <--> Library: PriorityQueueFactory (at address: 0xe7CD38fE96A4D1A72856199a62752C585EAdF566)
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     Deploying 'RootChain'
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     ---------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > transaction hash:    0x8e1f8af15a141a801beb9e6feb6a9a7b1e501f88b4227fd1a093c507789d14e6
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > Blocks: 0            Seconds: 0
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > contract address:    0x4E6c34276C5F91593249D2a0598f994bA0B13D27
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > block number:        1008
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > block timestamp:     1569952354
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > account:             0xF7527026CEf1042f59301D151e9B87398b87d482
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > balance:             115792089237316195423570985008687907853269984665640564039154.598408773129639927
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > gas used:            5810203
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > gas price:           20 gwei
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > value sent:          0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]     > total cost:          0.11620406 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.120 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.121 [info]     > Saving migration to chain.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.121 [info]     > Saving artifacts
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.121 [info]     -------------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.129 [info]     > Total cost:          0.13299108 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  4_init_rootchain_contract.js
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  ============================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     > Saving migration to chain.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     -------------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     > Total cost:                   0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  5_output_results.js
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  ===================
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  {"contract_addr":"0x4e6c34276c5f91593249d2a0598f994ba0b13d27","txhash_contract":"0x8e1f8af15a141a801beb9e6feb6a9a7b1e501f88b4227fd1a093c507789d14e6","authority_addr":"0x2b89590cdbe7117f457891e0c19845cf447fd78a"}
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     > Saving migration to chain.
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     -------------------------------------
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]     > Total cost:                   0 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  Summary
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  =======
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  > Total deployments:   4
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]  > Final cost:          0.13685754 ETH
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]
plasma-deployer_1  |
plasma-deployer_1  | 17:52:54.135 [info]

Expected Behavior

To be able to deploy ALD contracts to chain with truffle

Steps to Reproduce

git checkout integration_949_elixir_omg_pr npx truffle migrate --network local --reset

Suggested Fix

/

Motivation for Change

Elixir OMG uses truffle for local cluster deploy.

System Specs

FROM erlang:21-alpine

MAINTAINER Ino Murko <ino@omise.co>

# Create and set home directory
WORKDIR /opt/plasma_deployer

# Configure required environment
ENV MIX_ENV prod

# elixir expects utf8.
ENV ELIXIR_VERSION="v1.8.2" \
    LANG=C.UTF-8

RUN set -xe \
    && ELIXIR_DOWNLOAD_URL="https://github.com/elixir-lang/elixir/archive/${ELIXIR_VERSION}.tar.gz" \
    && ELIXIR_DOWNLOAD_SHA256="cf9bf0b2d92bc4671431e3fe1d1b0a0e5125f1a942cc4fdf7914b74f04efb835" \
    && buildDeps=' \
        ca-certificates \
        curl \
        make \
    ' \
    && apk add --no-cache --virtual .build-deps $buildDeps \
    && curl -fSL -o elixir-src.tar.gz $ELIXIR_DOWNLOAD_URL \
    && echo "$ELIXIR_DOWNLOAD_SHA256  elixir-src.tar.gz" | sha256sum -c - \
    && mkdir -p /usr/local/src/elixir \
    && tar -xzC /usr/local/src/elixir --strip-components=1 -f elixir-src.tar.gz \
    && rm elixir-src.tar.gz \
    && cd /usr/local/src/elixir \
    && make install clean \
    && apk del .build-deps

#lets add plasma contract to the dir
RUN apk add --no-cache git
RUN git clone https://github.com/omisego/plasma-contracts .
RUN git checkout integration_949_elixir_omg_pr
#RUN git checkout 67b90e5175cd1e4d503ad0160cb069565ef91136

COPY mix.* ./
COPY . .

RUN mix do local.hex --force, local.rebar --force
RUN mix deps.get
RUN MIX_ENV=prod mix escript.build

###node for truffle
RUN apk add --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/v3.7/main/ nodejs=10.14.2-r0
RUN apk add --update npm
RUN apk add --update \
    python \
    python-dev \
    py-pip \
    build-base \
  && pip install virtualenv \
  && rm -rf /var/cache/apk/*

#last bits to get things going, npm install from contracts
RUN npm install
# curl for healthchecks
RUN apk add --no-cache curl

CMD [ "./plasma_deployer" ]
boolafish commented 5 years ago

I will try to merge this into master today: https://github.com/omisego/plasma-contracts/pull/298

Then there would be migration script directly on master. I am not really into the idea of supporting a special branching.....and aside from migration script there is some python tests commits but I don't think it really matters to elixir integration.

If you think that specific branch is necessary we can rebase that to master afterward, or merge the python test PR ASAP.

InoMurko commented 5 years ago

Sounds great! I don’t have any special requests 😁

boolafish commented 5 years ago

with #298 and #332 merged, I think everything needed is in master now.