Block.merkilize_transaction_set should not be a property

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma

MIT License

561 stars 158 forks source link

Block.merkilize_transaction_set should not be a property #101

Closed smartcontracts closed 6 years ago

smartcontracts commented 6 years ago

Block currently specifies merkilize_transaction_set as a property, but it should probably be a function:

    @property
    def merkilize_transaction_set(self):
        hashed_transaction_set = [transaction.merkle_hash for transaction in self.transaction_set]
        self.merkle = FixedMerkle(16, hashed_transaction_set, hashed=True)
        return self.merkle.root