Make Block.merkilize_transaction_set a function

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma

MIT License

561 stars 158 forks source link

Closed nvonpentz closed 6 years ago

nvonpentz commented 6 years ago

Resolves #101

Please let me know if I should add tests.

Minor, I also noticed 'merkel' is spelled 'merkle' or 'merkil' throughout.

smartcontracts commented 6 years ago

Thank you for this PR! Much appreciated.

Minor, I also noticed 'merkel' is spelled 'merkle' or 'merkil' throughout

It's correctly "Merkle," but merkilize is definitely wrong. Can we go ahead and refactor this to merklize? Seems to be the prevailing spelling.

smartcontracts commented 6 years ago

Otherwise, LGTM :+1: signing off on this.

nvonpentz commented 6 years ago

It's correctly "Merkle," but merkilize is definitely wrong. Can we go ahead and refactor this to merklize? Seems to be the prevailing spelling.

You're right, changing now.

DavidKnott commented 6 years ago

LGTM, @nvonpentz mind rebasing?

nvonpentz commented 6 years ago

@DavidKnott Rebased 👍