omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Clearly define plasma-mvp branches #114

Closed kasima closed 6 years ago

kasima commented 6 years ago
smartcontracts commented 6 years ago

Agreed on clearly defining each branch.

Should we also clearly define "reference"? We're already pretty far from Vitalik's original spec, so it might be useful to come up with a clear spec for the base Plasma MVP we're building here.

kasima commented 6 years ago

Spoke to @DavidKnott about it this morning. He thinks we're just about ready to branch off a reference branch. Perhaps after merging #109.

@kfichter – Is there anything else we might want merge before doing that? Do we need to define what we mean by reference further?

smartcontracts commented 6 years ago

As per call w/ @kasima, I don't think we need to merge anything else before branching off (maybe testing lang?). Only concern is MVP's underspecification, so I think we should document any significant differences between MVP and our reference implementation.

kasima commented 6 years ago

:+1: merging #92 as part of reference

smartcontracts commented 6 years ago

Should we close and move discussion to plasma-contracts?

kasima commented 6 years ago

Yep, this is no longer applicable.