search

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Solution to Issue #161 - Many Failing Test Cases #163

Closed bh2smith closed 6 years ago

bh2smith commented 6 years ago

Quick fix to recover passing test cases mentioned in #161

Also, added one line to .gitignore (for PyCharm IDE)

bh2smith commented 6 years ago

Notice that the above change also repairs the sendtx OMG command.

PaulRBerg commented 6 years ago

You could add the .idea folder in your global gitignore.

PaulRBerg commented 6 years ago

On OSX and python 3.6, I get the same number of failing tests, 11, that is, on both the main repo and your fork.

bh2smith commented 6 years ago

@PaulRBerg; You're comments lead me to believe you aren't up to date with the most recent commits. 

checkout 04df88122689b5e050e9e11da39b3c8ede02e157
PaulRBerg commented 6 years ago

I simply cloned the repo and ran make test right away, thus I should've had the latest version.

04df88122689b5e050e9e11da39b3c8ede02e157 seems to be 4 commits behind the latest one, so I'm not entirely sure what you're referring to.

I ran it anyway on that commit but I still got the same number of errors.

bh2smith commented 6 years ago

I just mentioned the old commit because that is where .idea had already been included in the .gitignore. Couldn't say where the errors are coming from, because I am experiencing no difficulties. I have been working in a different branch (dev) lately and merged it to my master just now in case this is where the errors were coming from.

bh2smith commented 6 years ago

@PaulRBerg Maybe you could provide more details about your failing tests. Perhaps the error messages? I suspect that cloning a repo and running make test could lead to some issues with dependencies.