omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Support Python 3.7 #172

Closed smartcontracts closed 6 years ago

smartcontracts commented 6 years ago

Issue Type

[ ] bug report
[x] feature request

Current Behavior

Everything breaks when we use Python 3.7 as a result of a dependency on asyncio and some keyword conflicts. See issue #167 for more information.

Expected Behavior

Tests should work on Python 3.7.

Steps to Reproduce

  1. Use Python 3.7
  2. Try to test (make test)
  3. See everything break.

Suggested Fix

Use Python 3.6 for now, try to find a fix for this (probably upgrade websockets?)

Motivation for Change

Lots of people use py3.7, we should support it.

smartcontracts commented 6 years ago

Seems like we should be able to fix this by bumping Web3.py to 4.5.0 (?). Testing now.