#186 - Improve security on Validate.checkSigs

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma

MIT License

561 stars 158 forks source link

#186 - Improve security on Validate.checkSigs #187

Closed bh2smith closed 5 years ago

bh2smith commented 6 years ago

This should fix the security issue from Issue - #186 where the value true is returned on essentially any arbitrary values being passed into the function.

smartcontracts commented 5 years ago

Hmm. Maybe we should have Validate throw instead?

bh2smith commented 5 years ago

Yes actually, I have found some other issues and since fixed them, will post next proposed solution soon!

smartcontracts commented 5 years ago

Closing in favor of #191 for now, let's open a new PR if you have more changes.