search

omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Clean up unit tests #69

Open smartcontracts opened 6 years ago

smartcontracts commented 6 years ago

Our tests are starting to become extremely large. We should clean things up so they're easier to read and understand.

test_root_chain.py seems like a good place to start.

hamdiallam commented 6 years ago

why not make the rootchain smart contract isolated in a truffle project and use mocha to test. A suggestion

jeamick commented 6 years ago

hello @kfichter ,

Any update about what @hamdiallam mentioned ?

What do you mean by clean up unit tests ?

Maybe having separated python test with Several folder could improve readability ?

Thanks for your response

smartcontracts commented 6 years ago

I'm very much considering this! I'm going to discuss it further with a few people, but it seems like it'd be most useful to have the contracts as a truffle project and the client as something separate. The original motivation was to share the core components (plasma_core) to avoid duplicating work.

kasima commented 6 years ago

I like this plan. This would be a good place to start with truffle and move the work over to the plasma-contracts repo.