omgnetwork / plasma-mvp

OmiseGO's research implementation of Minimal Viable Plasma
MIT License
561 stars 158 forks source link

Deposit blocks are not signed before being included in the list of blocks. #81

Closed ggs134 closed 6 years ago

ggs134 commented 6 years ago

In child_chain.py,

If a block in is signed, then this block is appended to variable.

It is block signing process.

However, when deposit tx and make a block, this block does not signed but included in variables.

I think signing process should be implemented at child_chain.py, apply_deposit() function.

And merkle, too.

paulperegud commented 6 years ago

Deposit blocks are signed by depositor and their correctness is guaranteed by Ethereum. Signature of operator does not add anything of value.

smartcontracts commented 6 years ago

Closing as operator does not need to sign deposit blocks